Update readme to match svn and improve it minorly #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-domain-check Add `Plugin_Header_Text_Domain_Check` static check
…check Add Late Escaping Check
Remove PHP 5.6 from unit test
Bump Node to v16
Bump dependencies to latest version
Fix typos in the plugin
Add Spell Check action
…dependencies Fix error shows by `composer validate`
While this is usefull for theme devs too, I think it's aimed at Plugin devs
Member
|
@aaronjorbin thank you so much for the contribution, the not matching is because we are running a separate branch for the pre-version 1.0.0 which will be based on the work the performance team. Current branch with the code: A little bit more context on #253. Would you mind if I pointed your change to that branch? So we can get that readme fix? |
Member
Author
|
@bordoni Thanks, that totally makes sense. I'm going to close this and open a new one since as you see above, everything goes a little haywire since this branch was based off main. |
aaronjorbin
added a commit
to aaronjorbin/plugin-check
that referenced
this pull request
Sep 21, 2023
* Imports readme from SVN * Updates some text formatting issues * Fixes an issue where theme is referenced instead of plugin See WordPress#257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The Readme doesn't match the one in SVN. The SVN one also says
This is very handy for theme developers, or anybody looking to make sure that their plugin supports, I changed that to say it's very handy for plugin developers.How to test the Change
Proofread and make sure I copy and pasted correctly.
Changelog Entry
Credits
Just me.
Checklist: