Create Runtime_Environment_Setup and object-cache.php #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjgrainger
added
[Type] Enhancement
joemcgill
reviewed
Feb 17, 2023
Member
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Looking good. Left a few questions/suggestions.
felixarntz
requested changes
Feb 17, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger Overall this looks very solid, just one critical (yet small) thing missing here. I left a few other smaller points of feedback.
felixarntz
reviewed
Feb 21, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger A few small last things here, but this looks almost good to go.
joemcgill
approved these changes
Feb 22, 2023
Member
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
I left a couple questions, but not blocking unless you think they need to be addressed. The updates look good to me 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses acceptance criteria in #42
Closes #42