Merged
Conversation
wu-sheng
reviewed
Jan 11, 2022
wu-sheng
reviewed
Jan 11, 2022
test/e2e/e2e-test/nginx/src/test/java/org/apache/skywalking/e2e/DataAssertITCase.java
Show resolved
Hide resolved
wu-sheng
reviewed
Jan 11, 2022
test/e2e/e2e-test/nginx/src/test/java/org/apache/skywalking/e2e/DataAssertITCase.java
Show resolved
Hide resolved
wu-sheng
reviewed
Jan 11, 2022
dmsolr
reviewed
Jan 11, 2022
added 2 commits
January 11, 2022 17:15
wu-sheng
reviewed
Jan 11, 2022
wu-sheng
reviewed
Jan 11, 2022
wu-sheng
reviewed
Jan 11, 2022
wu-sheng
reviewed
Jan 11, 2022
Member
Member
Author
added 2 commits
January 12, 2022 13:33
Member
|
hi, @alonelaval the CI installation of OpenResty includes luajit, try to use |
Member
Author
no work,in my local why luarocks installed package 'luaunit' not found. |
added 2 commits
January 12, 2022 17:58
wu-sheng
reviewed
Jan 13, 2022
wu-sheng
reviewed
Jan 13, 2022
wu-sheng
reviewed
Jan 13, 2022
wu-sheng
reviewed
Jan 13, 2022
added 2 commits
January 13, 2022 15:10
Member
|
@membphis @dmsolr @tzssangglass Could you review the PR again? |
wu-sheng
reviewed
Jan 13, 2022
licenses/LICENSE-luaffi.txt
Outdated
| @@ -0,0 +1,58 @@ | |||
| BSD License | |||
|
|
|||
| For luaffifb software | |||
Member
There was a problem hiding this comment.
A thing, why do we have this update? I think we don't copy the luaffi source codes.
dmsolr
approved these changes
Jan 13, 2022
wu-sheng
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.