Skip to content

Conversation

@albers
Copy link
Collaborator

@albers albers commented Oct 19, 2024

- What I did
Fixed the "legacy" bash completion for events --filter daemon= that no longer works.

- How I did it
Changed completion logic from parsing the bare docker info output to using a --filter matching the desired values.

- How to verify it
type

docker events --filter daemon=<tab><tab>

Before: no completion
With this fix: completion of ID and hostname of the current docker daemon.

- Description for the changelog
Fixed bash completion for events --filter daemon=

Fixed bash completion for `events --filter daemon=`

- A picture of a cute animal (not mandatory but encouraged)

@albers albers requested a review from a team as a code owner October 19, 2024 15:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.57%. Comparing base (21eea1e) to head (3f7b156).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5554      +/-   ##
==========================================
- Coverage   60.67%   59.57%   -1.10%     
==========================================
  Files         345      345              
  Lines       23491    29088    +5597     
==========================================
+ Hits        14252    17330    +3078     
- Misses       8266    10788    +2522     
+ Partials      973      970       -3     

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🙏

@thaJeztah thaJeztah added this to the 28.0.0 milestone Oct 19, 2024
@thaJeztah thaJeztah merged commit 062eecf into docker:master Oct 19, 2024
@albers albers deleted the fix-completion-events-filter-daemon branch October 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants