Conversation
...s/10.0/10.0.0/api-diff/Microsoft.WindowsDesktop.App/10.0.0_System.Threading.AccessControl.md
Outdated
Show resolved
Hide resolved
|
Thanks for publishing this before GA day! I was hoping this diff would be at |
|
I don't know if we actually need folks to individually review here, should we "trust the process"? |
|
I agree. We should merge and allow for people to make edits afterwards if they find mistakes. The review always takes a long time and the feedback (if any) is always super targeted. It would be great however if we could move the location of the diff, however, first. |
| } | ||
| - namespace System.Collections.ObjectModel | ||
| - { | ||
| - public class ReadOnlySet<T> : System.Collections.Generic.ICollection<T>, System.Collections.Generic.IEnumerable<T>, System.Collections.IEnumerable, System.Collections.Generic.IReadOnlyCollection<T>, System.Collections.Generic.IReadOnlySet<T>, System.Collections.Generic.ISet<T>, System.Collections.ICollection |
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
I just double checked this for sanity. The type got moved from System.Collections.dll to System.Runtime.dll in the reference assembly: https://github.com/dotnet/core/pull/10147/files#diff-2bf320cc1e60dff83561a22e9f25b68d2133f5c1d1de3327df8a515827ae58d1R97
|
Sorry if you were still making changes @PranavSenthilnathan. I didn't notice that. Seemed time to merge the branch. |
|
Nope, I just merged in #10180 to fix the last failing CI check. |
Library area owners: