Remove TextLayoutBuilder from ReactAndroid dependency#20600
Closed
dulmandakh wants to merge 4 commits intofacebook:masterfrom
Closed
Remove TextLayoutBuilder from ReactAndroid dependency#20600dulmandakh wants to merge 4 commits intofacebook:masterfrom
dulmandakh wants to merge 4 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
dulmandakh
changed the title
react-native-bot
added
Platform: Android
gengjiawen
approved these changes
Aug 9, 2018
Contributor
Author
|
@hramos please view and merge |
Contributor
|
Importing without approval, as we need to check if this is OK to remove internally. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
I didn't find any internal callsites, it seems like it should be good to land. Still, it's waiting for approval from a teammate. |
Collaborator
|
@dulmandakh merged commit 7ff9352 into Once this commit is added to a release, you will see the corresponding version tag below the description at 7ff9352. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Aug 23, 2018
Summary: This PR removes TextLayoutBuilder, which is not used anywhere. Pull Request resolved: #20600 Reviewed By: achen1 Differential Revision: D9367345 Pulled By: hramos fbshipit-source-id: 407a6a80f5c69650fcc7167b28214f7315beed2f
aleclarson
pushed a commit
to aleclarson/react-native
that referenced
this pull request
Sep 16, 2018
Summary: This PR removes TextLayoutBuilder, which is not used anywhere. Pull Request resolved: facebook#20600 Reviewed By: achen1 Differential Revision: D9367345 Pulled By: hramos fbshipit-source-id: 407a6a80f5c69650fcc7167b28214f7315beed2f
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This PR removes TextLayoutBuilder, which is not used anywhere. Pull Request resolved: facebook#20600 Reviewed By: achen1 Differential Revision: D9367345 Pulled By: hramos fbshipit-source-id: 407a6a80f5c69650fcc7167b28214f7315beed2f
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This PR removes TextLayoutBuilder, which is not used anywhere. Pull Request resolved: facebook#20600 Reviewed By: achen1 Differential Revision: D9367345 Pulled By: hramos fbshipit-source-id: 407a6a80f5c69650fcc7167b28214f7315beed2f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes TextLayoutBuilder, which is not used anywhere.
Test Plan:
Everything builds and runs as usual