Fix E2E warnings#22621
Closed
CodingItWrong wants to merge 3 commits intofacebook:masterfrom
CodingItWrong:fix-e2e-warnings
Closed
Fix E2E warnings#22621CodingItWrong wants to merge 3 commits intofacebook:masterfrom CodingItWrong:fix-e2e-warnings
CodingItWrong wants to merge 3 commits intofacebook:masterfrom
CodingItWrong:fix-e2e-warnings
Conversation
facebook-github-bot
added
CLA Signed
kelset
approved these changes
Dec 12, 2018
Contributor
kelset
left a comment
kelset
left a comment
There was a problem hiding this comment.
LGTM ✅
Thanks for the PR Josh!
Contributor
Author
|
Objc: |
Contributor
Author
|
I reconfirmed the Detox tests work for me locally. Fixing whatever broke the Objc tests might fix Detox as well; I think we should not worry about the Detox ones yet. |
matthargett
approved these changes
Dec 12, 2018
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 14, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@CodingItWrong merged commit ac30f64 into |
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Fixes two types of warnings that occur when running E2E tests: 1. A deprecation warning from Jest: 'Option "setupTestFrameworkScriptFile" was replaced by configuration "setupFilesAfterEnv", which supports multiple paths.' 2. YellowBox warnings when running the app in debug mode, about components that are deprecated and that require main queue setup. By fixing these warnings, we increase contributors' confidence that things are working correctly, and draw attention to any warnings that they _should_ pay attention to, if and when they arise. I feel confident that we should hide the deprecated-component warnings; we _want_ to use these components because we want them to be tested, until they're removed entirely. For the warning "Module RCTImagePickerManager requires main queue setup", if that's something that can be fixed with reasonable effort in the RNTester code then I think it would be better to do so. Otherwise, I think it is good to hide the warning, because this is a condition we expect: it's not something a contributor should pay attention to. Pull Request resolved: facebook/react-native#22621 Differential Revision: D13468553 Pulled By: hramos fbshipit-source-id: 1a5952087dd6fcc9ba08ff7a60ad9f5b075bef57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two types of warnings that occur when running E2E tests:
By fixing these warnings, we increase contributors' confidence that things are working correctly, and draw attention to any warnings that they should pay attention to, if and when they arise.
I feel confident that we should hide the deprecated-component warnings; we want to use these components because we want them to be tested, until they're removed entirely.
For the warning "Module RCTImagePickerManager requires main queue setup", if that's something that can be fixed with reasonable effort in the RNTester code then I think it would be better to do so. Otherwise, I think it is good to hide the warning, because this is a condition we expect: it's not something a contributor should pay attention to.
Test Plan:
Run:
You should not see any warnings in the console, or any YellowBox warnings in the simulator.
Changelog:
[General] [Fixed] - Fix E2E warnings