More helpful message if you update an unrendered component

[clayallsopp]

We had a logic bug in our app where replaceProps was called before the component was renderComponent'd. The current error thrown is Uncaught TypeError: Cannot read property 'constructor' of undefined, which isn't super helpful.

Not sure this is the best/correct way to do this, but would love to know what is :)

[zpao]

I think this might be better protected against by inspecting lifecycle state. We do something similar for replaceState in composite components...

And now that I'm looking more, we actually protect against this in receiveProps but setProps doesn't go through that path. I think we could use some consolidation but for the time being, let's put an invariant into replaceProps that does exactly what receiveProps does. Give that a try and see if it fixes your case! (and if you wrote a test to ensure you get that error, that would be cool too 😉)

[clayallsopp]

@zpao updated, with a test

[zpao]

👍 I'm pulling this in for review internally right now

[zpao]

We can fit this whole var instance = .... onto a single line, so lets do that.

[clayallsopp]

Cool, done! Any reason grunt lint doesn't pick up the 80 char limit?

[zpao]

It's a soft limit but we try to stick to it as much as possible. It would be great to make it possible to have multiple passes so that we could give a warning but not fail (the maxlen option results in errors if we turn it on). Internally we have the tooling set up to warn when linting but not block commits (unlike other lint errors).

[zpao]

Accepted. Thanks a lot @clayallsopp!