Load extension styles with relevant core blocks#2591
Merged
AnthonyLedesma merged 4 commits intomasterfrom Feb 28, 2024
Merged
Conversation
EvanHerman
approved these changes
Feb 28, 2024
Contributor
EvanHerman
left a comment
There was a problem hiding this comment.
Appears to be working well on my end 👍
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Load extension styles for specific core block styles.
This moves the styles out of global
style-coblocks-1.cssfile intostyle-coblocks-extensions.It also ensures that expected extension styles are loaded for the respective core blocks.
New tests to validate proper enqueue for expected blocks.
Screenshots
Before

After

Types of changes
Php changes to enqueue logic, relocation of styles, and some extension files for consistency.
How has this been tested?
Tested manually, tested with Unit Tests.
Acceptance criteria
Must enqueue block style css when only the core block is used.
core/imagecore/buttoncore/listcore/media-textcore/coverChecklist: