Fix disappearing buttons inside of Services blocks#2613
Merged
AnthonyLedesma merged 2 commits intomasterfrom Jun 13, 2024
Merged
Fix disappearing buttons inside of Services blocks#2613AnthonyLedesma merged 2 commits intomasterfrom
AnthonyLedesma merged 2 commits intomasterfrom
Conversation
snovosel-godaddy
approved these changes
Jun 10, 2024
AnthonyLedesma
requested changes
Jun 10, 2024
Member
AnthonyLedesma
left a comment
There was a problem hiding this comment.
This test must be changed
coblocks/src/blocks/services/test/services.cypress.js
Lines 91 to 107 in 0206e8e
AnthonyLedesma
approved these changes
Jun 13, 2024
Member
AnthonyLedesma
left a comment
There was a problem hiding this comment.
Great work. I was not able to break the block, or trigger a deprecation error. Should be good to release.
This was referenced Jul 25, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed 'Display button' toggle from the services and service blocks.
Link to issue WPEX-3677
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Manual regression testing
Acceptance criteria
'Display button' toggle should be completely removed after deciding to allow users to place buttons within the inner blocks if they choose.
Checklist: