Skip to content

fix: remove unnecessary dependency on libcst#308

Merged
tswast merged 3 commits intogoogleapis:masterfrom
tswast:issue302-libcst
Oct 8, 2020
Merged

fix: remove unnecessary dependency on libcst#308
tswast merged 3 commits intogoogleapis:masterfrom
tswast:issue302-libcst

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Oct 7, 2020

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #302 🦕

@tswast tswast requested a review from a team October 7, 2020 16:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@tswast
Copy link
Contributor Author

tswast commented Oct 7, 2020

Ran synthtool locally and verified that the "fixup" script stays excluded.

@tswast tswast merged commit c055930 into googleapis:master Oct 8, 2020
@tswast tswast deleted the issue302-libcst branch October 8, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-bigquery not compatible with pandas-gbq error

2 participants