Port to Python 3.11: use Py_SET_SIZE()#114
Merged
martindurant merged 1 commit intointake:masterfrom Dec 8, 2021
vstinner:python311
Merged
Port to Python 3.11: use Py_SET_SIZE()#114martindurant merged 1 commit intointake:masterfrom vstinner:python311
martindurant merged 1 commit intointake:masterfrom
vstinner:python311
Conversation
On Python 3.11, "Py_SIZE(str) = actual_size;" fails with a compiler error. Since Python 3.9, Py_SET_SIZE() must be used instead: * https://docs.python.org/dev/whatsnew/3.11.html#c-api-changes * https://docs.python.org/dev/c-api/structures.html#c.Py_SIZE Add a copy of the pythoncapi_compat.h header file to get Py_SET_SIZE() on Python 3.8 and older: https://github.com/pythoncapi/pythoncapi_compat
Member
|
I am no expert, so hopefully someone else can confirm this is good. If there are no objections, I can merge it in a couple of days. |
Contributor
Author
|
Without my change, the build fails: With the change, the build completes succesfully: |
Contributor
Author
|
Nice, thanks ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3.11, "Py_SIZE(str) = actual_size;" fails with a compiler
error. Since Python 3.9, Py_SET_SIZE() must be used instead:
Add a copy of the pythoncapi_compat.h header file to get
Py_SET_SIZE() on Python 3.8 and older:
https://github.com/pythoncapi/pythoncapi_compat