Skip to content

Conversation

@sohag-pro
Copy link
Contributor

Here you go.

:)

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sohag-pro
Copy link
Contributor Author

/done

Copy link
Member

@jaamaalxyz jaamaalxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ভাই আগের রিভিউয়ে আজকের বিষয় গুলো হইত চোখে পড়ে নি। দুঃখিত আপনাকে সঠিক ভাবে গাইড করতে না পারায়। আপনার কাজ আমাদের কমিউনিটির জন্য অনেক গুরুত্তপূর্ণ। আমাদের সাথে থাকার জন্য ধন্যবাদ। এবারের ইস্যু গুলো ফিক্স করে কমিট করলে মারজ হয়ে যাবে আশা করছি।

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sohag-pro
Copy link
Contributor Author

/done

Copy link

@ta-riq ta-riq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we dont need to translate the texts inside code blocks. Isn't that mentioned in the rules ?

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sohag-pro
Copy link
Contributor Author

/done

@jaamaalxyz
Copy link
Member

I think we don't need to translate the texts inside code blocks. Isn't that mentioned in the rules?

Brother @ta-riq we can change the string inside any code blocks and also we translate comments. otherwise, code blocks are not changeable. thanks for your opinions.

Copy link
Member

@jaamaalxyz jaamaalxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost ok, thanks for your great work brother @shuvo575

@jaamaalxyz jaamaalxyz merged commit 0ca35bd into javascript-tutorial:master Oct 27, 2019
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Copy link

@ta-riq ta-riq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants