Fix non-native fullscreen quit to black screen bug#1516
Merged
ychin merged 1 commit intomacvim-dev:masterfrom Dec 21, 2024
Merged
Fix non-native fullscreen quit to black screen bug#1516ychin merged 1 commit intomacvim-dev:masterfrom
ychin merged 1 commit intomacvim-dev:masterfrom
Conversation
A previous change macvim-dev#1510 introduced a piece of debug code that erroneously overrode the `window` property to always return the normal window whereas in normal behavior it should return the full screen window when in non-native full screen. This property was only added for supporting unit tests and also completely unnecessary because the superclass `NSWindowController` already provides it (the one that we accidentally overrode). Just remove this. Fix macvim-dev#1515
Member
Author
|
Will add better regression tests for full screen in the future. Currently, the entire full screen feature isn't really tested which is not ideal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous change #1510 introduced a piece of debug code that erroneously overrode the
windowproperty to always return the normal window whereas in normal behavior it should return the full screen window when in non-native full screen. This property was only added for supporting unit tests and also completely unnecessary because the superclassNSWindowControlleralready provides it (the one that we accidentally overrode). Just remove this.Fix #1515