Improve type guards for type variables#15576
Merged
ahejlsberg merged 5 commits intomasterfrom May 7, 2017
Merged
Conversation
mhegazy
reviewed
May 6, 2017
|
|
||
| function isApparentTypePosition(node: Node) { | ||
| const parent = node.parent; | ||
| return parent.kind === SyntaxKind.PropertyAccessExpression || |
Contributor
There was a problem hiding this comment.
&& (<PropertyAccessExpression >parent).expression === node; ?
Member
Author
There was a problem hiding this comment.
No need to. This function is only ever called on the left hand side of a property access expression (the right hand side is just an identifier and not actually an expression).
mhegazy
approved these changes
May 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, when a node is the left hand expression of a property access, element access, or call expression, and the type of the node includes type variables with constraints that are nullable, we fetch the apparent type of the node before performing control flow analysis such that narrowings apply to the constraint type. For example:
Prior to this PR, the property access, element access, and call expressions above were errors.
Fixes #14091.
Fixes #14415.