Conversation
ghost
requested a review
from 
Contributor
|
@Andy-MS can you add a note about it in the API breaking changes section. |
mhegazy
approved these changes
May 31, 2018
Author
|
Don't think it's an API breaking change since this wasn't in the public API? |
Contributor
|
I remember monaco used to take a dependency on it. but they do not any longer. even though it is not part of the public API ppl still use it. we just need to add a note to use |
Author
|
Updated API breaking changes. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only history I can find on this is af5148d -- since this method is internal there should be no problem removing it?