🤖 User test baselines have changed#25294
Merged
DanielRosenwasser merged 1 commit intomicrosoft:masterfrom Jun 28, 2018
Merged
Conversation
typescript-bot
force-pushed
the
user-update-20180504
branch
from
190609a to
2af923b
Compare
| @@ -0,0 +1,7 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/@types/passport-facebook/index.d.ts(50,31): error TS2689: Cannot extend an interface 'passport.Strategy'. Did you mean 'implements'? | |||
Member
There was a problem hiding this comment.
@Andy-MS, can you take a look at what happened here?
There was a problem hiding this comment.
I don't see this with a fresh npm install. Do you know what command the bot runs?
Member
There was a problem hiding this comment.
npm i --no-save --ignore-scripts
There was a problem hiding this comment.
I did:
jake cleanjake localgit submodule update tests/cases/user/TypeScript-Node-Starter/cd tests/cases/user/TypeScript-Node-Starter/TypeScript-Node-Starterrm -r node_modulesnpm i --no-save --ignore-scriptsnode ../../../../../built/local/tsc.js
I see compile errors in mocha, jquery, and lodash. @types/passport-facebook is installed but I don't see any compile errors there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @mhegazy