Fix type parameter inference cache invalidation logic#32362
Merged
ahejlsberg merged 3 commits intomasterfrom Jul 12, 2019
Merged
Fix type parameter inference cache invalidation logic#32362ahejlsberg merged 3 commits intomasterfrom
ahejlsberg merged 3 commits intomasterfrom
Conversation
Member
Author
|
@typescript-bot run dt |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 4b9ca33. You can monitor the build here. It should now contribute to this PR's status checks. |
Collaborator
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 4b9ca33. You can monitor the build here. It should now contribute to this PR's status checks. |
Member
Author
|
No changes in RWC baselines compared to master (all errors are preexisting conditions). |
Member
Author
|
Errors in DT test runs are unrelated to this PR. |
weswigham
approved these changes
Jul 12, 2019
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
Seems good - any non-fixed inferredType was potentially generated with other non-fixed types, so when we fix or update one, we should refresh them all.
RyanCavanaugh
approved these changes
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32230.