Fix default property assigned prototype#40836
Merged
Conversation
The check in getAssignedClassSymbol forgot to allow for default-property assignment declarations, in part because it wasn't using a utility function to do so.
typescript-bot
added
Author: Team
For Milestone Bug
sandersn
commented
Sep 29, 2020
| const exprType = checkJsxAttribute(attributeDecl, checkMode); | ||
| objectFlags |= getObjectFlags(exprType) & ObjectFlags.PropagatingFlags; | ||
|
|
||
| const attributeSymbol = createSymbol(SymbolFlags.Property | SymbolFlags.Transient | member.flags, member.escapedName); |
Member
Author
There was a problem hiding this comment.
this is a drive-by fix; createSymbol always adds Transient.
| isVariableDeclaration(decl.parent) && getSymbolOfNode(decl.parent)); | ||
| const prototype = assignmentSymbol && assignmentSymbol.exports && assignmentSymbol.exports.get("prototype" as __String); | ||
| const init = prototype && prototype.valueDeclaration && getAssignedJSPrototype(prototype.valueDeclaration); | ||
| const assignmentSymbol = decl && getSymbolOfExpando(decl, /*allowDeclaration*/ true); |
src/compiler/checker.ts
Outdated
| return init ? getSymbolOfNode(init) : undefined; | ||
| } | ||
|
|
||
| function getSymbolOfExpando(node: Node, allowDeclaration?: boolean): Symbol | undefined { |
Member
Author
There was a problem hiding this comment.
changes from the move:
- Return a Symbol instead of a Node, since all callers immediately do that anyway. This is why I moved it into the checker.
- Add a parameter
allowDeclarationthat allowsnodeto be either the expando or its declaration. The parameter disables the checks that assert thatnodeis theexpandoinitialiser. - Add a FunctionDeclaration case when
allowDeclarationis true.
andrewbranch
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check in getAssignedClassSymbol forgot to allow for default-property assignment declarations, in part because it wasn't using a utility function to do so.
Fixes #39167