feat(26217): Add missing member fix should work for missing function#41215
Merged
jessetrinity merged 6 commits intomicrosoft:masterfrom Jan 9, 2021
Merged
feat(26217): Add missing member fix should work for missing function#41215jessetrinity merged 6 commits intomicrosoft:masterfrom
jessetrinity merged 6 commits intomicrosoft:masterfrom
Conversation
a-tarasyuk
force-pushed
the
feat/26217
branch
from
a1d9f1f to
dc448f9
Compare
DanielRosenwasser
requested review from
DanielRosenwasser,
jessetrinity and
sandersn
Member
|
@typescript-bot pack this |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at dc448f9. You can monitor the build here. |
Collaborator
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build. |
sandersn
approved these changes
Dec 19, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Just a couple of early comments -- I've looked at the tests, and they look good, but haven't looked at the code.
tests/cases/fourslash/importNameCodeFixNewImportNodeModules5.ts
Outdated
Show resolved
Hide resolved
a-tarasyuk
force-pushed
the
feat/26217
branch
from
127e16e to
f322ed6
Compare
5 tasks
jessetrinity
reviewed
Jan 5, 2021
Contributor
jessetrinity
left a comment
jessetrinity
left a comment
There was a problem hiding this comment.
I left a couple of questions but otherwise looks great 👍
jessetrinity
approved these changes
Jan 9, 2021
Zzzen
pushed a commit
to Zzzen/TypeScript
that referenced
this pull request
Jan 16, 2021
…icrosoft#41215) * feat(26217): Add missing function declaration QF * use codeFixAvailable instead of codeFix * add diagnostics messages 'Method not implemented.' and 'Function not implemented.' * use codeFixAvailable instead of codeFix * fix signature types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26217