Compress buildinfo by changing how affectedFilesPendingEmit are stored#51246
Compress buildinfo by changing how affectedFilesPendingEmit are stored#51246sheetalkamat merged 1 commit intomainfrom
Conversation
|
I think the description basically says that, rather than emitting both a |
|
If the flag can differ from file to file (is that actually the case?), then would it be even more compact to just have two lists: files pending full emit and files pending dts emit? Edit: I found a test showing that it's possible. It's still not clear how much overhead splitting the list would have and it might regress some scenarios (e.g. the (contrived) tests), so we can probably ignore this for now. |
amcasey
left a comment
There was a problem hiding this comment.
I can't see a scenario where this is worse than the status quo, but it does make me wonder whether we should just emit a binary file.
A file is stored as just
fileIdif pending on "Full" emit and as[fileId]if its pending on Dts so this avoids codingBuilderFileEmitKindsaving some bytes. Becasue in most cases it will be full emit pending (eg if there are errors) it is used asfileId.