Conditionally set originalKeywordKind on Identifiers

[DanielRosenwasser]

Experiment for #51496.

[DanielRosenwasser]

@typescript-bot perf test this faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at f8df1ca. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51498

Metric	main	51498	Delta	Best	Worst
Angular - node (v16.17.1, x64)
Memory used	340,522k (± 0.02%)	338,501k (± 0.02%)	-2,022k (- 0.59%)	338,316k	338,574k
Parse Time	1.88s (± 0.66%)	1.91s (± 0.30%)	+0.02s (+ 1.22%)	1.89s	1.92s
Bind Time	0.65s (± 0.89%)	0.65s (± 0.56%)	+0.00s (+ 0.15%)	0.65s	0.66s
Check Time	5.16s (± 0.38%)	5.21s (± 0.62%)	+0.05s (+ 0.91%)	5.15s	5.30s
Emit Time	5.11s (± 0.76%)	5.12s (± 0.77%)	+0.01s (+ 0.16%)	5.04s	5.24s
Total Time	12.81s (± 0.46%)	12.89s (± 0.39%)	+0.08s (+ 0.63%)	12.77s	12.99s
Compiler-Unions - node (v16.17.1, x64)
Memory used	188,257k (± 0.65%)	185,852k (± 0.38%)	-2,404k (- 1.28%)	185,486k	188,728k
Parse Time	0.79s (± 0.75%)	0.80s (± 0.75%)	+0.00s (+ 0.00%)	0.78s	0.81s
Bind Time	0.42s (± 0.53%)	0.42s (± 1.18%)	-0.00s (- 1.19%)	0.41s	0.43s
Check Time	6.05s (± 0.72%)	6.01s (± 0.73%)	-0.04s (- 0.71%)	5.88s	6.10s
Emit Time	1.91s (± 0.72%)	1.91s (± 0.89%)	+0.00s (+ 0.05%)	1.87s	1.94s
Total Time	9.17s (± 0.47%)	9.13s (± 0.65%)	-0.05s (- 0.51%)	8.96s	9.24s
Monaco - node (v16.17.1, x64)
Memory used	319,866k (± 0.01%)	319,520k (± 0.02%)	-346k (- 0.11%)	319,336k	319,602k
Parse Time	1.43s (± 0.73%)	1.44s (± 0.47%)	+0.01s (+ 0.63%)	1.42s	1.45s
Bind Time	0.59s (± 1.00%)	0.60s (± 1.00%)	+0.00s (+ 0.34%)	0.59s	0.61s
Check Time	4.87s (± 0.39%)	4.90s (± 0.33%)	+0.02s (+ 0.45%)	4.86s	4.93s
Emit Time	2.72s (± 0.90%)	2.75s (± 0.85%)	+0.04s (+ 1.32%)	2.70s	2.81s
Total Time	9.61s (± 0.40%)	9.68s (± 0.40%)	+0.07s (+ 0.69%)	9.59s	9.77s
TFS - node (v16.17.1, x64)
Memory used	282,300k (± 0.01%)	282,039k (± 0.02%)	-261k (- 0.09%)	281,834k	282,112k
Parse Time	1.17s (± 0.51%)	1.16s (± 0.98%)	-0.00s (- 0.34%)	1.14s	1.19s
Bind Time	0.65s (± 3.63%)	0.66s (± 3.04%)	+0.01s (+ 1.38%)	0.62s	0.69s
Check Time	4.76s (± 0.39%)	4.78s (± 0.35%)	+0.01s (+ 0.27%)	4.74s	4.81s
Emit Time	2.76s (± 2.01%)	2.71s (± 1.43%)	-0.05s (- 1.96%)	2.64s	2.84s
Total Time	9.35s (± 0.72%)	9.31s (± 0.60%)	-0.04s (- 0.42%)	9.22s	9.46s
material-ui - node (v16.17.1, x64)
Memory used	435,297k (± 0.01%)	433,897k (± 0.00%)	-1,400k (- 0.32%)	433,865k	433,933k
Parse Time	1.65s (± 0.50%)	1.65s (± 0.63%)	-0.01s (- 0.36%)	1.62s	1.67s
Bind Time	0.50s (± 0.98%)	0.51s (± 1.02%)	+0.01s (+ 1.39%)	0.50s	0.52s
Check Time	11.96s (± 0.42%)	11.96s (± 0.89%)	-0.00s (- 0.03%)	11.76s	12.20s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	14.13s (± 0.36%)	14.12s (± 0.79%)	-0.01s (- 0.06%)	13.90s	14.37s
xstate - node (v16.17.1, x64)
Memory used	516,263k (± 0.01%)	512,839k (± 0.01%)	-3,424k (- 0.66%)	512,691k	513,007k
Parse Time	2.33s (± 0.45%)	2.33s (± 0.45%)	+0.00s (+ 0.09%)	2.31s	2.35s
Bind Time	0.84s (± 1.90%)	0.84s (± 2.46%)	0.00s ( 0.00%)	0.81s	0.91s
Check Time	1.36s (± 0.50%)	1.36s (± 0.24%)	+0.00s (+ 0.29%)	1.35s	1.37s
Emit Time	0.06s (± 0.00%)	0.06s (± 0.00%)	0.00s ( 0.00%)	0.06s	0.06s
Total Time	4.60s (± 0.44%)	4.60s (± 0.53%)	+0.00s (+ 0.04%)	4.56s	4.66s

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-131-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	51498	10
Baseline	main	10

Developer Information:

Download Benchmark

[DanielRosenwasser]

I think we would prefer to remove them entirely.