Support Trailing Commas#7747
Closed
YuichiNukiyama wants to merge 1 commit intomicrosoft:masterfrom
YuichiNukiyama:fix7279
Closed
Support Trailing Commas#7747YuichiNukiyama wants to merge 1 commit intomicrosoft:masterfrom YuichiNukiyama:fix7279
YuichiNukiyama wants to merge 1 commit intomicrosoft:masterfrom
YuichiNukiyama:fix7279
Conversation
When TS compile function parameter list, `checkForTrailingComma` do't be used In parser.ts. So, I change check.ts and related tests.
|
|
||
| function checkGrammarForDisallowedTrailingComma(list: NodeArray<Node>): boolean { | ||
| if (list && list.hasTrailingComma) { | ||
| if (list && list.hasTrailingComma && |
Member
There was a problem hiding this comment.
Why not just remove the calls in checkGrammarArguments and checkGrammarParameterList ?
Member
|
Just as a note, we need to check whether the services layer, and the compiler itself, still resolves overloads correctly. |
ghost
mentioned this pull request
Contributor
|
This should be addressed by #8942. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7279
When TS compile function parameter list,
checkForTrailingCommado't be used In parser.ts. So, I change check.ts and related tests.