Allow trailing commas in function parameter and argument lists#8942
Merged
5 commits merged intomasterfrom Jun 7, 2016
Merged
Conversation
ghost
force-pushed
the
param_trailing_commas
branch
from
c8c6503 to
4281bf5
Compare
Contributor
|
can you also add a test for trailing commas after a rest arg. |
Contributor
|
👍 |
added 2 commits
June 3, 2016 09:29
ghost
mentioned this pull request
Author
|
Need review on 2fc2f5c |
Contributor
|
looks good. |
Contributor
|
i would also add a test for getters, setters, call and construct signatures. |
| tests/cases/conformance/es7/trailingCommasInFunctionParametersAndArguments.ts(20,11): error TS1138: Parameter declaration expected. | ||
|
|
||
|
|
||
| ==== tests/cases/conformance/es7/trailingCommasInFunctionParametersAndArguments.ts (1 errors) ==== |
Member
There was a problem hiding this comment.
that's weird, I wasn't expecting to see a .errors.txt and a .types. Usually they are mutually exclusive. Did the .types file manage to skip the broken getter/setter pair?
Member
|
👍 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7279
If this is pulled we should close #7747 too.