Add new private class element helper: __classPrivateFieldIn#157
Merged
sandersn merged 2 commits intomicrosoft:mainfrom Sep 24, 2021
Merged
Add new private class element helper: __classPrivateFieldIn#157sandersn merged 2 commits intomicrosoft:mainfrom
sandersn merged 2 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: aclaymore <aclaymore@bloomberg.net>
1 task
sandersn
approved these changes
Sep 24, 2021
sandersn
requested changes
Sep 24, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Tests fail -- they didn't run automatically. =(
Signed-off-by: aclaymore <aclaymore@bloomberg.net>
sandersn
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A companion to microsoft/TypeScript#44648 - this PR adds the
__classPrivateFieldInhelper used when transforming#field in expression.cc: @rbuckton @sandersn