Added completion entry for @ts-expect-error directive#92093
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Mar 9, 2020
JoshuaKGoldberg:ts-expect-error-completion
Merged
Added completion entry for @ts-expect-error directive#92093mjbvz merged 3 commits intomicrosoft:masterfrom JoshuaKGoldberg:ts-expect-error-completion
mjbvz merged 3 commits intomicrosoft:masterfrom
JoshuaKGoldberg:ts-expect-error-completion
Conversation
Contributor
Author
|
Monaco's build failures are not related to this PR: 🙃 hooray |
Collaborator
|
Change LGTM. Can you also create an issue on the VS Code side so we can track this feature and make sure we test it at the end of the iteration |
mjbvz
reviewed
Mar 5, 2020
extensions/typescript-language-features/src/features/directiveCommentCompletions.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Thanks! This is scheduled for VS Code 1.44 and should be in the upcoming insiders builds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on microsoft/TypeScript#36014 by adding
ts-expect-erroras a completion directive, and recommends it over@ts-ignorein the editor walkthrough.I'm happy to file a corresponding issue per the PR template if you'd prefer - figured a PR first would be easier if this is a no brainer. Thanks!Fixes #92116