Skip to content

http,http2: make early hints generic #44820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 7 commits into from
Oct 6, 2022
Merged

http,http2: make early hints generic #44820

nodejs-github-bot merged 7 commits into from
Oct 6, 2022

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Sep 29, 2022 •
edited by RaisinTen
Loading

Make early hints receive object as a parameter.
Fixes: #44816

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 29, 2022

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Sep 29, 2022
@anonrig anonrig marked this pull request as ready for review September 29, 2022 14:21
climba03003
climba03003 reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@climba03003 climba03003 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early Hints is not released in any version of node.
I believe the implementation here can change to plain object or Array.

It does not require a special case for Link only.

Uzlopak
Uzlopak reviewed Sep 29, 2022
View reviewed changes
RafaelGSS
RafaelGSS reviewed Sep 30, 2022
View reviewed changes
@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 30, 2022

I know you closed the remark regarding the regex. But could you please open an issue, so that this is tracked?

@anonrig anonrig mentioned this pull request Sep 30, 2022
Closed
mcollina
mcollina approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Oct 2, 2022

Can you update the PR title and commit line to be prefixed http,http2:?

mcollina
mcollina approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig changed the title http2: make early hints generic http,http2: make early hints generic Oct 2, 2022
@anonrig
Copy link
Member Author

anonrig commented Oct 2, 2022

Updated the title @mcollina

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 2, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46993/

RafaelGSS
RafaelGSS approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2022
@anonrig anonrig mentioned this pull request Oct 3, 2022
Merged
climba03003
climba03003 reviewed Oct 3, 2022
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
@nodejs-github-bot nodejs-github-bot merged commit 37f1e4b into nodejs:main Oct 6, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 6, 2022

Landed in 37f1e4b

@mcollina mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 6, 2022
@mcollina mcollina mentioned this pull request Oct 6, 2022
Merged
This was referenced Oct 7, 2022
Open
Open
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
@meyfa meyfa mentioned this pull request Oct 14, 2022
Merged
@danielroe danielroe mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@JungMinu JungMinu JungMinu approved these changes

+3 more reviewers

@Uzlopak Uzlopak Uzlopak left review comments

@zekth zekth zekth left review comments

@climba03003 climba03003 climba03003 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http: make early hints implementation more generic

9 participants

@anonrig @nodejs-github-bot @Uzlopak @mcollina @jasnell @JungMinu @zekth @climba03003 @RafaelGSS