HSOptical Sample#1630
Merged
IgorOchocki merged 1 commit intooneapi-src:developmentfrom May 10, 2023
ShwethaSelma:hsoptical_b1
Merged
HSOptical Sample#1630IgorOchocki merged 1 commit intooneapi-src:developmentfrom ShwethaSelma:hsoptical_b1
IgorOchocki merged 1 commit intooneapi-src:developmentfrom
ShwethaSelma:hsoptical_b1
Conversation
Signed-off-by: ShwethaSelma <shwethasshetty27@gmail.com>
IgorOchocki
approved these changes
May 9, 2023
Contributor
IgorOchocki
left a comment
IgorOchocki
left a comment
There was a problem hiding this comment.
Looks good to me. @jkinsky can you please accept the changes in the README file?
ghost
approved these changes
May 9, 2023
Contributor
|
use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Fix for error on PVC machine, since sample uses sycl::image class - Code checks for devices that are compatible with sycl image class. CMakefile change to execute on gpu and cpu seperately.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration