Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a check added by #1393 trying to fix #1338. The check only accounted for MSYS2 environments that used GCC. #1135 was later merged that added detection for Windows consoles, which would have also addressed the issue. I confirmed that
click.echoandclick.progressbarcontinued to work with the MSYS2 check removed, for msys2 and cygwin environments (which Python sees as posix) and mingw-w64 (which Python sees as Windows). fixes #2355I also noticed that there was a check for Google App Engine. This check seems to be from when GAE still supported Python 2, and provided a special local dev server environment. The GAE standard environment sets different env vars now, and the local dev server appears to just run Python in Windows still (and is de-emphasized over running the usual
flaskdev server). I've removed that check as well.