feat: new method for choice fail#2622
Merged
AndreasBackx merged 8 commits intopallets:mainfrom Nov 3, 2024
Merged
Conversation
AndreasBackx
requested changes
Oct 26, 2024
Collaborator
AndreasBackx
left a comment
There was a problem hiding this comment.
This seems like a fine choice. Could you follow through with the rest of the checklist like documentation and tests?
327e06e to
0fb1d4c
Compare
Contributor
Author
|
I did my best to complete the checkboxes. Notes:
|
Co-authored-by: Andreas Backx <AndreasBackx@users.noreply.github.com>
0fb1d4c to
723b0c4
Compare
Collaborator
|
@antazoey thanks for getting back so quickly and my apologies for taking another week myself. I've wrapped it up and merged it, thank you for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors so the failing happens in a new public method.
click.types.Choice#2621Ensure each step in CONTRIBUTING.rst is complete by adding an "x" to
each box below.
If only docs were changed, these aren't relevant and can be removed.
-->
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.