Using correct typing for param_hint#2990
Merged
Rowlando13 merged 2 commits intopallets:stablefrom Jul 22, 2025
Merged
Conversation
Contributor
Author
|
There's not |
FirelightFlagboy
force-pushed
the
fix-typing-bad-param
branch
from
0c55379 to
2abb2d6
Compare
Collaborator
|
@kdeldycke would you mind checking this? |
Collaborator
|
@FirelightFlagboy Please rebase onto stable since this will go out in the next bug fix release. |
FirelightFlagboy
force-pushed
the
fix-typing-bad-param
branch
from
2abb2d6 to
4b14faf
Compare
Contributor
Author
|
@Rowlando13 done, I've rebased to |
The typing of `param_hint` between `BadParameter`, `MissingParameter` and `_join_param_hints` was different. The firsts only allowed for a `str` where the later also accept a sequence of `str`. Fixes pallets#2777
FirelightFlagboy
force-pushed
the
fix-typing-bad-param
branch
from
4b14faf to
3155dca
Compare
davidism
changed the title
param_hintparam_hint
Collaborator
I don't see any issue here! :) Good to be merged back to 8.2.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typing of
param_hintbetweenBadParameter,MissingParameterand_join_param_hintswas different. The firsts only allowed for astrwhere the later also accept a sequence ofstr.Fixes #2777