Fix crash in hooked iterator on properties array without dynamic properties#15394
Merged
iluuu1994 merged 1 commit intophp:masterfrom Aug 19, 2024
Merged
Fix crash in hooked iterator on properties array without dynamic properties#15394iluuu1994 merged 1 commit intophp:masterfrom
iluuu1994 merged 1 commit intophp:masterfrom
Conversation
Member
Author
|
Actually, there's another issue: class Test {
public int $prop { set => $value; }
}
$test = new Test();
var_dump($test);
foreach ($test as $key => $value) {
var_dump($key, $value);
}This currently prints NULL, but the property should be skipped instead... I'll have a look tomorrow. |
Member
Author
|
Ok, both issues should be fixed now. I changed the implementation to set data/key to null on reset/forward, and fetch the data (if it wasn't already) on valid/get_current_data. Fetching the data includes moving forward further if the data is unavailable, both for declared and dynamic properties. |
arnaud-lb
approved these changes
Aug 14, 2024
Member
arnaud-lb
left a comment
There was a problem hiding this comment.
Looks good to me apart from one comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix incorrect usage of zend_read_property_ex().
Fixes GH-15187