Attaching thumb file while editing message media.#2583
Attaching thumb file while editing message media.#2583Bibo-Joshi merged 13 commits intopython-telegram-bot:masterfrom
Conversation
If the media has a thumb, we also need to attach it to the data.
|
hey, have you read the contributing guidelines? The tests will keep failing here otherwise. |
No, that is a lot works to do in guideline! |
|
shout once you done that (or gave up and I can try to guide you in the correct direction then), and I shall review the code :D |
|
Ok, @Poolitzer |
Okay, great. I will have time to do this next week. |
Fix test.
Adding my name!
Update test_inputmedia.py
Poolitzer
left a comment
Poolitzer
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the effort and persistence.
|
Thank you @Poolitzer, I could not do it without your help, you are the best ;D |
|
Just one question @Poolitzer : Why did you rebase to v14? I would see this as bug fix and merge this into master … |
|
@Bibo-Joshi Hm. I wasn't sure we wanted to do a bug fix release. But we can ofc |
|
Thanks for the contribution @paradox70 ! |
Fix Setting Thumbs When Uploading A Single File (python-telegram-bot#2583)
4 participants
PTB doesn't attach thumb file while editing media.
I tested the changes manually and it works, but I'm not sure about writing tests in true way.