Fix in docs string#3007
Merged
Bibo-Joshi merged 1 commit intopython-telegram-bot:doc-fixesfrom May 8, 2022
KnorpelSenf:patch-1
Merged
Fix in docs string#3007Bibo-Joshi merged 1 commit intopython-telegram-bot:doc-fixesfrom KnorpelSenf:patch-1
Bibo-Joshi merged 1 commit intopython-telegram-bot:doc-fixesfrom
KnorpelSenf:patch-1
Conversation
harshil21
reviewed
May 7, 2022
| If you'd like to make sure that the Webhook request comes from Telegram, Telegram | ||
| recommends using a secret path in the URL, e.g. https://www.example.com/<token>. Since | ||
| nobody else knows your bot's token, you can be pretty sure it's us. | ||
| nobody else knows your bot's token, you can be pretty sure it's them. |
Member
There was a problem hiding this comment.
Suggested change
| nobody else knows your bot's token, you can be pretty sure it's them. | |
| nobody else knows your bot's token, you can be pretty sure it's Telegram. |
I would change it to Telegram since it makes more clear who it is, rather than us (PTB or Telegram?) and them (Telegram or the attackers?)
But let's see what the other maintainers think
Contributor
Author
There was a problem hiding this comment.
Please @ me when you have agreed on something, I'm fine with both, but slightly prefer them because it's been mentioned several times in the sentence before that we're talking about Telegram.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not read your template, sorry, just wanted to fix this one word.