fix the missing notes about telegram.ext.JobQueue#3600
Merged
Bibo-Joshi merged 4 commits intopython-telegram-bot:doc-fixesfrom Mar 19, 2023
beiluonever:patch-1
Merged
fix the missing notes about telegram.ext.JobQueue#3600Bibo-Joshi merged 4 commits intopython-telegram-bot:doc-fixesfrom beiluonever:patch-1
Bibo-Joshi merged 4 commits intopython-telegram-bot:doc-fixesfrom
beiluonever:patch-1
Conversation
if not use `pip install python-telegram-bot[job-queue]` to install PTB, will get `AttributeError: 'NoneType' object has no attribute 'get_jobs_by_name'` error.
Bibo-Joshi
requested changes
Mar 19, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hi, thanks for finding this mistake in out docs! Let's align the change with the other examples :)
thanks Bibo suggestions Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Contributor
Author
already applied suggestions, thanks . |
Member
|
Many thanks again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if not use
pip install python-telegram-bot[job-queue]to install PTB, will getAttributeError: 'NoneType' object has no attribute 'get_jobs_by_name'error in this example.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__sIf the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-onlyAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesMessage.effective_attachmentConversationHandler_extbot.pybot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFOtg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message