Merged
Conversation
Poolitzer
requested changes
Apr 2, 2023
Member
Poolitzer
left a comment
Poolitzer
left a comment
There was a problem hiding this comment.
Just different wording suggestions, code is a great change!
telegram/ext/_application.py
Outdated
Comment on lines
1385
to
1386
| Note that for data that should be available globally in all handler callbacks, | ||
| independent of the chat/user, it is recommended use :attr:`bot_data` instead. |
Member
There was a problem hiding this comment.
Suggested change
| Note that for data that should be available globally in all handler callbacks, | |
| independent of the chat/user, it is recommended use :attr:`bot_data` instead. | |
| Note that for data which should be available globally in all handler callbacks, | |
| e.g. independent of the chat/user, it is recommended to use :attr:`bot_data` instead. |
telegram/ext/_application.py
Outdated
Comment on lines
1432
to
1434
| For :attr:`user_data` and :attr:`chat_data`, only those entries are updated that were used | ||
| or manually marked via :meth:`mark_data_for_update_persistence` since the last run of this | ||
| method. |
Member
There was a problem hiding this comment.
Suggested change
| For :attr:`user_data` and :attr:`chat_data`, only those entries are updated that were used | |
| or manually marked via :meth:`mark_data_for_update_persistence` since the last run of this | |
| method. | |
| For :attr:`user_data` and :attr:`chat_data`, only the entries are updated which either were | |
| used or have been manually marked via :meth:`mark_data_for_update_persistence` since | |
| the last run of this method. |
Bibo-Joshi
added
🔌 enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3554. Closes #3601
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Added myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__s