Make JobQueues APS-Interface more explicit#3695
Merged
Bibo-Joshi merged 11 commits intomasterfrom Jun 2, 2023
Merged
Conversation
Member
lemontree210
left a comment
There was a problem hiding this comment.
Not much I can contribute here except probably ask for more clarity as to what benefits using this new method offers.
Member
Author
|
Another comment on this. This PR does not ensure that the classes
IMO making
|
harshil21
reviewed
May 29, 2023
lemontree210
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by python-telegram-bot/ptbcontrib#72 and python-telegram-bot/ptbcontrib#73
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)[ ] Added myself alphabetically toAUTHORS.rst(optional)[ ] Added new classes & modules to the docs and all suitable__all__s