Issue 1943 allow jscode in options#2029
Merged
hansthen merged 8 commits intopython-visualization:mainfrom Nov 17, 2024
Merged
Conversation
Conengmo
requested changes
Nov 17, 2024
Member
Conengmo
left a comment
Conengmo
left a comment
There was a problem hiding this comment.
Boring but big 😄 Kudos for taking this on. It looks good! I have two small comments, plus some suggestions to remove added print statements from tests. Other than that looks good!
Co-authored-by: Frank Anema <33519926+Conengmo@users.noreply.github.com>
Co-authored-by: Frank Anema <33519926+Conengmo@users.noreply.github.com>
Co-authored-by: Frank Anema <33519926+Conengmo@users.noreply.github.com>
Co-authored-by: Frank Anema <33519926+Conengmo@users.noreply.github.com>
Co-authored-by: Frank Anema <33519926+Conengmo@users.noreply.github.com>
Collaborator
Author
|
@Conengmo Perhaps you can also have a look at the |
Member
|
Yes, I noticed that one as well. Can't think of a good, simple solution right now, so maybe what you did is best for now. |
This was referenced Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boring but big. The leaflet class hierarchy allows all classes to have optional arguments. These optional arguments can contain JavaScript code or references to other Leaflet elements.
To support this in Folium I replaced (almost) all instances of
parse_optionsin the constructors withthis.options | tojavascriptin the templates. I left theparse_optionsin case someone outside of Folium uses it.