urlparse.urlunsplit should be smarter about +

[dabrahams]

BPO	8657
Nosy	@orsenthil, @dabrahams
Files	urlparse_giturl.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2010-05-13.03:49:07.003>
created_at = <Date 2010-05-08.02:49:07.152>
labels = ['type-bug']
title = 'urlparse.urlunsplit should be smarter about +'
updated_at = <Date 2010-05-13.03:49:07.001>
user = 'https://github.com/dabrahams'

bugs.python.org fields:

activity = <Date 2010-05-13.03:49:07.001>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2010-05-13.03:49:07.003>
closer = 'orsenthil'
components = []
creation = <Date 2010-05-08.02:49:07.152>
creator = 'dabrahams'
dependencies = []
files = ['17258']
hgrepos = []
issue_num = 8657
keywords = ['patch']
message_count = 3.0
messages = ['105253', '105280', '105622']
nosy_count = 3.0
nosy_names = ['orsenthil', 'meatballhat', 'dabrahams']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue8657'
versions = ['Python 2.6']

[dabrahams]

from urlparse import *
urlunsplit(urlsplit('git+file:///foo/bar/baz'))
=> git+file:/foo/bar/baz

[meatballhat]

Is simply adding 'git+' entries comprehensive enough? I'd have said the same thing about the addition of the 'svn+' entries, fwiw :) Is adding hardcoded entries like this the preferred way to extend urlparse?

[orsenthil]

I have added 'git' and 'git+ssh' under known schemes which will recognize authority/netloc and follow consistent round trip parsing behaviors.

For any unknown scheme(x or git+file), it might required to update the uses_netloc in the application.

git+ and svn+ might not be a good idea, as git+foobar like terms might cause ambiguity.

Fixed in r81130, r81131, r81132 and r81133.