Speedup test_unparse

[jkloth]

BPO	47131
Nosy	@vstinner, @jkloth, @pablogsal
PRs	bpo-47131: Speedup AST comparisons in test_unparse by using node traversal #32132

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-04-05.17:32:41.737>
created_at = <Date 2022-03-26.19:15:49.915>
labels = ['3.11', 'tests', '3.9', '3.10', 'performance']
title = 'Speedup test_unparse'
updated_at = <Date 2022-04-05.17:32:41.736>
user = 'https://github.com/jkloth'

bugs.python.org fields:

activity = <Date 2022-04-05.17:32:41.736>
actor = 'jkloth'
assignee = 'none'
closed = True
closed_date = <Date 2022-04-05.17:32:41.737>
closer = 'jkloth'
components = ['Tests']
creation = <Date 2022-03-26.19:15:49.915>
creator = 'jkloth'
dependencies = []
files = []
hgrepos = []
issue_num = 47131
keywords = ['patch']
message_count = 3.0
messages = ['416082', '416529', '416791']
nosy_count = 3.0
nosy_names = ['vstinner', 'jkloth', 'pablogsal']
pr_nums = ['32132']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue47131'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[jkloth]

The string building and comparing of ast.dump() causes significant slowdowns on the large ASTs produced when doing the roundtrip test on the stdlib.

This PR avoids that cost by doing a direct node traversal and comparison. It results in a 33% runtime improvement on machines to which I have access.

[pablogsal]

New changeset 0f68c20 by Jeremy Kloth in branch 'main':
bpo-47131: Speedup AST comparisons in test_unparse by using node traversal (GH-32132)
0f68c20

[jkloth]

Resolved with merged PR.