Skip to content

gh-86493: Fix possible leaks in modules initialization: _curses_panel, _decimal, posix, xxsubtype#106767

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:pymodule-add4a
Jul 18, 2023
Merged

gh-86493: Fix possible leaks in modules initialization: _curses_panel, _decimal, posix, xxsubtype#106767
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:pymodule-add4a

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 15, 2023 •
edited by bedevere-bot
Loading

Use PyModule_AddObjectRef(...) instead of PyModule_AddObject(..., Py_NewRef(...)).

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 15, 2023
Closed
@rhettinger rhettinger removed their request for review July 15, 2023 20:33
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 17, 2023
Merged
@serhiy-storchaka serhiy-storchaka merged commit 7454923 into python:main Jul 18, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 18, 2023

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 18, 2023

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12

@miss-islington
Copy link
Contributor

miss-islington commented Jul 18, 2023

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.11

@serhiy-storchaka serhiy-storchaka deleted the pymodule-add4a branch July 18, 2023 06:00
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 18, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 18, 2023

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 18, 2023

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 18, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 18, 2023

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 18, 2023

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.12] pythongh-86493: Fix possible leaks in modules initialization: …
d158e97 
…_curses_panel, _decimal, posix, xxsubtype (pythonGH-106767).

(cherry picked from commit 7454923)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 18, 2023

GH-106849 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 18, 2023
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.11 only security fixes label Jul 18, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 18, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.12] gh-86493: Fix possible leaks in modules initialization: _curse…
970cb8e 
…s_panel, _decimal, posix, xxsubtype (GH-106767) (#106849)

(cherry picked from commit 7454923)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] [3.12] pythongh-86493: Fix possible leaks in modules initializ…
b0b65c1 
…ation: _curses_panel, _decimal, posix, xxsubtype (pythonGH-106767) (pythonGH-106849)

(cherry picked from commit 7454923).
(cherry picked from commit 970cb8e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner
Copy link
Member

vstinner commented Jul 18, 2023

It's so hard to get PyInit code right :-( Thanks for the fix.

serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] gh-86493: Fix possible leaks in modules initialization: _curse…
3841af4 
…s_panel, _decimal, posix, xxsubtype (GH-106767) (GH-106849) (GH-106851)

(cherry picked from commit 7454923)
(cherry picked from commit 970cb8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @vstinner