gh-106368: Argument clinic: Fix minor bug in state_modulename_name#107387
Merged
AlexWaygood merged 2 commits intopython:mainfrom Jul 28, 2023
Merged
gh-106368: Argument clinic: Fix minor bug in state_modulename_name#107387AlexWaygood merged 2 commits intopython:mainfrom
state_modulename_name#107387AlexWaygood merged 2 commits intopython:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
serhiy-storchaka
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clson this line could beNone, which causes the test case I'm adding in this PR to fail withAttributeError: 'NoneType' object has no attribute 'functions'on themainbranch.cpython/Tools/clinic/clinic.py
Line 4713 in 0aa58fa
(This failure path is currently not covered by any test cases, as far as I can tell. The bug is flagged by mypy if you add type annotations to the last remaining untyped function in
clinic.py,_module_and_class().)@erlend-aasland: this is another one that could be backported, since it's technically a bugfix, but to me feels minor enough to not be worth it.