[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976)#112059
Merged
serhiy-storchaka merged 2 commits intopython:3.11from Nov 15, 2023
Merged
[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976)#112059serhiy-storchaka merged 2 commits intopython:3.11from
serhiy-storchaka merged 2 commits intopython:3.11from
Conversation
…-111976) * Fix crash when encoding is not string or None. * Fix crash when both line_buffering and write_through raise exception when converted ti int. * Add a number of tests for constructor and reconfigure() method with invalid arguments. (cherry picked from commit ee06fff) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Nov 14, 2023
Member
|
test_io failed on Address Sanitizer job: This PR should be backport to 3.11 with its fix. I will wait until #112089 is merged into 3.12. |
…tor (pythonGH-112061) (pythonGH-112089) In non-debug more the check for the "errors" argument is skipped, and then PyUnicode_AsUTF8() can fail, but its result was not checked. Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 9302f05) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when converted ti int.
with invalid arguments.
(cherry picked from commit ee06fff)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com