Skip to content

gh-60346: Improve handling single-dash options in ArgumentParser.parse_known_args()#114180

Merged
serhiy-storchaka merged 7 commits intopython:mainfrom
serhiy-storchaka:argparse-parse_known_args-with-flags
Feb 19, 2024
Merged

gh-60346: Improve handling single-dash options in ArgumentParser.parse_known_args()#114180
serhiy-storchaka merged 7 commits intopython:mainfrom
serhiy-storchaka:argparse-parse_known_args-with-flags

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 17, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 17, 2024
Closed
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review February 4, 2024 15:45
@serhiy-storchaka serhiy-storchaka merged commit e47ecbd into python:main Feb 19, 2024
@serhiy-storchaka serhiy-storchaka deleted the argparse-parse_known_args-with-flags branch February 19, 2024 17:20
@serhiy-storchaka serhiy-storchaka mentioned this pull request Feb 19, 2024
Closed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 19, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 19, 2024

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Feb 19, 2024

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 19, 2024
@serhiy-storchaka @miss-islington
pythongh-60346: Improve handling single-dash options in ArgumentParse…
dae00e4 
…r.parse_known_args() (pythonGH-114180)

(cherry picked from commit e47ecbd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 19, 2024

GH-115674 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 19, 2024
@serhiy-storchaka @miss-islington
pythongh-60346: Improve handling single-dash options in ArgumentParse…
eadb768 
…r.parse_known_args() (pythonGH-114180)

(cherry picked from commit e47ecbd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 19, 2024

GH-115675 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 19, 2024
serhiy-storchaka added a commit that referenced this pull request Feb 19, 2024
@miss-islington @serhiy-storchaka
[3.11] gh-60346: Improve handling single-dash options in ArgumentPars…
c02b7ae 
…er.parse_known_args() (GH-114180) (GH-115674)

(cherry picked from commit e47ecbd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Feb 19, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-60346: Improve handling single-dash options in ArgumentPars…
cffb4c7 
…er.parse_known_args() (GH-114180) (GH-115675)

(cherry picked from commit e47ecbd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@serhiy-storchaka @woodruffw
pythongh-60346: Improve handling single-dash options in ArgumentParse…
be45e35 
…r.parse_known_args() (pythonGH-114180)
clalancette added a commit to colcon/colcon-core that referenced this pull request Apr 9, 2024
@clalancette
Fix argument parsing in newer Python.
3640bd0 
The comment in the code has more details, but as of
python/cpython#114180 we need to
check for both a 3-tuple and a 4-tuple.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette mentioned this pull request Apr 9, 2024
Merged
clalancette added a commit to colcon/colcon-core that referenced this pull request Apr 9, 2024
@clalancette
Fix argument parsing in newer Python.
6230515 
The comment in the code has more details, but as of
python/cpython#114180 we need to
check for both a 3-tuple and a 4-tuple.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit to colcon/colcon-core that referenced this pull request Apr 9, 2024
@clalancette
Fix argument parsing in newer Python.
b39c91c 
The comment in the code has more details, but as of
python/cpython#114180 we need to
check for both a 3-tuple and a 4-tuple.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit to colcon/colcon-core that referenced this pull request Apr 9, 2024
@clalancette
Fix argument parsing in newer Python.
9ec44f2 
The comment in the code has more details, but as of
python/cpython#114180 we need to
check for both a 3-tuple and a 4-tuple.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
cottsay pushed a commit to colcon/colcon-core that referenced this pull request Apr 9, 2024
@clalancette
Fix argument parsing in newer Python. (#635)
b04d936 
The comment in the code has more details, but as of
python/cpython#114180 we need to
check for both a 3-tuple and a 4-tuple.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@adamjstewart adamjstewart mentioned this pull request Apr 16, 2024
Closed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-60346: Improve handling single-dash options in ArgumentParse…
6dcdac5 
…r.parse_known_args() (pythonGH-114180)
gonsoos added a commit to gonsoos/pkgcheck that referenced this pull request May 8, 2024
@gonsoos
pyproject: bump snakeoil to restore compat with >=python-3.11.9
74b1c26 
ArgumentParser added a separator to its option tuple with
>=python-3.11.9, which snakeoil-0.10.7 does not handle correctly.
python/cpython#114180

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
gentoo-bot pushed a commit to pkgcore/pkgcheck that referenced this pull request May 8, 2024
@gonsoos @arthurzam
pyproject: bump snakeoil to restore compat with >=python-3.11.9
3860094 
ArgumentParser added a separator to its option tuple with
>=python-3.11.9, which snakeoil-0.10.7 does not handle correctly.
python/cpython#114180

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 23, 2024
Open
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@serhiy-storchaka @LukasWoodtli
pythongh-60346: Improve handling single-dash options in ArgumentParse…
360ebd8 
…r.parse_known_args() (pythonGH-114180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @furkanonder