gh-113317: Argument Clinic: Add libclinic.function

[vstinner]

• Move Module, Class, and Function and Parameter classes to a new libclinic.function module.
• Move VersionTuple and Sentinels to libclinic.utils.

• Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

[erlend-aasland]

Move Module, Class, Function and Parameter classes to a new libclinic.function module.

This naming does not make sense to me. Why would class, module and parameter live in a file called function.py?

[vstinner]

This naming does not make sense to me. Why would class, module and parameter live in a file called function.py?

Do you want to propose a different name? Or have one class per file?

[erlend-aasland]

Do you want to propose a different name? Or have one class per file?

With one class per file you at least don't need to git grep in order to find out where things live; if the file is named after the class, it would be obvious where it was defined. Perhaps that is too granular, though.

[erlend-aasland]

The commit message says:

Move Module, Class, Function and Parameter classes to a new libclinic.function module.

But this is not true; Parameter was not moved; it was left out of the PR.

[vstinner]

But this is not true; Parameter was not moved; it was left out of the PR.

Parameter was moved to libclinic.function in the merged commit, no? Search for class Parameter: in b1236a4. Well, I can be wrong.

[erlend-aasland]

No, you're right; I misread it in-between all the changes. Sorry!