gh-118650: Exclude _repr_* methods from Enum's _sunder_ reservation#118651
Merged
encukou merged 1 commit intopython:mainfrom May 7, 2024
Merged
gh-118650: Exclude _repr_* methods from Enum's _sunder_ reservation#118651encukou merged 1 commit intopython:mainfrom
_repr_* methods from Enum's _sunder_ reservation#118651encukou merged 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
chrysn
force-pushed
the
enum-allow-_repr_html_
branch
from
3651668 to
4f38131
Compare
ethanfurman
approved these changes
May 6, 2024
Member
ethanfurman
left a comment
ethanfurman
left a comment
There was a problem hiding this comment.
Looks good to me. I'll leave it open for a couple days to see if anybody else has thoughts about it.
Member
|
It would be nice to have a naming convention for third-party projects to reserve special names. Leaving this open for days means missing Beta 1, so I'd rather merge (and revert later if necessary). |
Member
|
@encukou Thanks, I hadn't realized beta 1 was near. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This carves out some space of Enum's reserved _sunder_ names, and allows
_repr_html_,_repr_pretty_and similar methods available in IPython's pretty printing to be implemented on enums.Closes: #118650