bpo-1054041: Re-init _Py_UnhandledKeyboardInterrupt before run.#11963
Merged
gpshead merged 1 commit intopython:masterfrom Feb 21, 2019
Merged
bpo-1054041: Re-init _Py_UnhandledKeyboardInterrupt before run.#11963gpshead merged 1 commit intopython:masterfrom
gpshead merged 1 commit intopython:masterfrom
Conversation
Explicitly reinitialize this every eval *just in case* someone is calling into an embedded Python where they don't care about an uncaught KeyboardInterrupt exception (why didn't they leave `config.install_signal_handlers` set to `0`?!?) but then later call `Py_Main()` itself (which *checks* this flag and dies with a signal after its interpreter exits). We don't want a previous embedded interpreter's uncaught exception to trigger an unexplained signal exit from a future `Py_Main()` based one.
Member
|
FWIW, another reason to do this is so changes to what bits of code check for the _Py_UnhandledKeyboardInterrupt variable (e.g. if it was moved to Py_Finalize) don't cause unintended behaviour changes in embedded Python interpreters. |
Yhg1s
approved these changes
Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly reinitialize this every eval just in case someone is
calling into an embedded Python where they don't care about an uncaught
KeyboardInterrupt exception (why didn't they leave
config.install_signal_handlersset to0?!?) but then later callPy_Main()itself (which checks this flag and dies with a signal afterits interpreter exits). We don't want a previous embedded interpreter's
uncaught exception to trigger an unexplained signal exit from a future
Py_Main()based one.https://bugs.python.org/issue1054041
aka #41078