GH-73991: Support copying directory symlinks on older Windows#120807
Merged
barneygale merged 2 commits intopython:mainfrom Jul 3, 2024
Merged
GH-73991: Support copying directory symlinks on older Windows#120807barneygale merged 2 commits intopython:mainfrom
barneygale merged 2 commits intopython:mainfrom
Conversation
Check for `ERROR_INVALID_PARAMETER` when calling `_winapi.CopyFile2()` and raise `UnsupportedOperation`. In `Path.copy()`, handle this exception and fall back to the `PathBase.copy()` implementation.
eryksun
reviewed
Jun 20, 2024
eryksun
reviewed
Jun 20, 2024
eryksun
approved these changes
Jun 27, 2024
Contributor
eryksun
left a comment
eryksun
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this. 🚀
Contributor
Author
|
Thank you Eryk! |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…ython#120807) Check for `ERROR_INVALID_PARAMETER` when calling `_winapi.CopyFile2()` and raise `UnsupportedOperation`. In `Path.copy()`, handle this exception and fall back to the `PathBase.copy()` implementation.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…ython#120807) Check for `ERROR_INVALID_PARAMETER` when calling `_winapi.CopyFile2()` and raise `UnsupportedOperation`. In `Path.copy()`, handle this exception and fall back to the `PathBase.copy()` implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for
ERROR_INVALID_PARAMETERwhen calling_winapi.CopyFile2()and raiseUnsupportedOperation. InPath.copy(), handle this exception and fall back to thePathBase.copy()implementation.No news as
Path.copy()is brand new.📚 Documentation preview 📚: https://cpython-previews--120807.org.readthedocs.build/