gh-123424: add ZipInfo._for_archive to set suitable default properties#123429
gh-123424: add ZipInfo._for_archive to set suitable default properties#123429jaraco merged 8 commits intopython:mainfrom
ZipInfo._for_archive to set suitable default properties#123429Conversation
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
Looking good. I have some thoughts about alternative approaches. Interested to hear what you think.
|
Is there anything else that needs to be changed/discussion in this PR? I had another PR #124435 (which has been completed) that conflicted with these changes. After merge, I can continue handle my PR :) |
|
I don't have time for this one sorry. I didn't implement the suggestion with composition due to other issues that seemed more pressing (and I don't plan to come back here before I'm done with providing HACL* HMAC, at least). |
jaraco
force-pushed
the
feat/zipfile-for-name-123424
branch
from
f578f66 to
44e7b75
Compare
jaraco
changed the title
ZipInfo.for_name to construct a ZipInfo for a file in an archiveZipInfo._for_archive to set suitable default properties
|
Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :( |
No need to apologize. Thanks for the original work and being proactive about your availability. |
…roperties (python#123429) --------- Co-authored-by: Jason R. Coombs <[email protected]>
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties --------- Co-authored-by: Jason R. Coombs <[email protected]>
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties --------- Co-authored-by: Jason R. Coombs <[email protected]>
3 participants
Closes #123424 .
📚 Documentation preview 📚: https://cpython-previews--123429.org.readthedocs.build/