gh-115999: Introduce helpers for (un)specializing instructions#126414
Merged
mpage merged 1 commit intopython:mainfrom Nov 6, 2024
Merged
gh-115999: Introduce helpers for (un)specializing instructions#126414mpage merged 1 commit intopython:mainfrom
mpage merged 1 commit intopython:mainfrom
Conversation
Consolidate the code to specialize/unspecialize instructions into two helper functions and use them in `_Py_Specialize_BinaryOp`. The resulting code is more concise and keeps all of the logic at the point where we decide to specialize/unspecialize an instruction. If folks are amenable to this change, we can incrementally introduce their use as we work through making each specialization family thread-safe.
Fidget-Spinner
approved these changes
Nov 5, 2024
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Nov 6, 2024
Contributor
|
Not sure what is going on here, but this has caused a mass failure of buildbots... I'm seeing it on the iOS buildbot, where it's failing to build the macOS host build, before it even gets to the iOS build: |
Contributor
|
@freakboy3742 - it's fixed in main now (by @Eclips4) |
Contributor
Author
Sorry this was my fault. I merged this after #126450 was merged, without merging main into this PR first. This should be fixed by #126517. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…ython#126414) Introduce helpers for (un)specializing instructions Consolidate the code to specialize/unspecialize instructions into two helper functions and use them in `_Py_Specialize_BinaryOp`. The resulting code is more concise and keeps all of the logic at the point where we decide to specialize/unspecialize an instruction.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…ython#126414) Introduce helpers for (un)specializing instructions Consolidate the code to specialize/unspecialize instructions into two helper functions and use them in `_Py_Specialize_BinaryOp`. The resulting code is more concise and keeps all of the logic at the point where we decide to specialize/unspecialize an instruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the code to specialize/unspecialize instructions into two helper functions and use them in
_Py_Specialize_BinaryOp. The result is more concise and keeps all of the logic at the point where we decide to specialize/unspecialize an instruction.If folks are amenable to this change, we can incrementally introduce their use as we work through making each specialization family thread-safe.
--disable-gilbuilds #115999